[SYCL][Driver] Move offload mismatch warning into SYCLActionBuilder #7434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SYCLActionBuilder handles the parsing of the arguments to determine the SYCL triples and architectures being used, so doing the check here means we can just re-use that rather than having to parse the triples and target arguments again. This fixes the issue where for CUDA and HIP the specific architecture is embedded in the offload binary section name but is passed as a different argument and is not in the triple of `-fsycl-targets`.
|
Failures are unrelated seems to be coming from a test change, see: |
mdtoguchi
changed the title
|
sort.cpp issue handled at intel/llvm-test-suite#1396 |
This was referenced Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SYCLActionBuilder handles the parsing of the arguments to determine the SYCL triples and architectures being used, so doing the check there means we can just re-use that rather than having to parse the triples and target arguments again.
This fixes the issue where for CUDA and HIP where the check failed to take into account the offload architecture and would just compare the section name that has the triple and the offload architecture against just the triple which would always fail even when the triples and offload architectures were otherwise matching.
The new binaries for the test where generated from a
dummy.cppC++ file containing justvoid foo() {}, and:This patch solves the incorrect warning issues reported in #6636 and #7300