[SYCL] Support negative filters for ONEAPI_DEVICE_SELECTOR #7309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmlueck
reviewed
Nov 8, 2022
Contributor
|
@RaviNarayanaswamy , |
Contributor
|
@lbushi25 , |
Contributor
Author
|
@bso-intel Yes, the documentation has been updated! |
gmlueck
reviewed
Nov 8, 2022
bso-intel
reviewed
Nov 8, 2022
| discarding filter match the device. In this case, the device remains unavailable as expected. | ||
|
|
||
| The following examples further illustrate the usage of this environment variable: | ||
|
|
Contributor
There was a problem hiding this comment.
Please add the exclamation mark ('!') in this bullet.
- The semi-colon character (
;) is treated specially by many shells, so you may need to enclose the string in quotes if the selection string contains this character.
lbushi25
commented
Nov 8, 2022
Contributor
LGTM |
Contributor
Author
cperkinsintel
approved these changes
Nov 9, 2022
Contributor
cperkinsintel
left a comment
cperkinsintel
left a comment
There was a problem hiding this comment.
One question, but otherwise LGTM.
Contributor
Author
|
pinging @intel/dpcpp-doc-reviewers @KseniyaTikhomirova for reachability since it has been open for a couple of days now. |
Contributor
Author
|
Hi,
The CI failures are unrelated to my changes. The test Regression/device_num.cpp has been fixed by #7336. The test regression/tanh_fix_test.cpp has been fixed by intel/llvm-test-suite#1372.
From: Kseniya Tikhomirova ***@***.***>
Sent: Thursday, November 10, 2022 11:45 AM
To: intel/llvm ***@***.***>
Cc: Bushi, Lorenc ***@***.***>; Mention ***@***.***>
Subject: Re: [intel/llvm] [SYCL] Support negative filters for ONEAPI_DEVICE_SELECTOR (PR #7309)
pinging @intel/dpcpp-doc-reviewers<https://github.com/orgs/intel/teams/dpcpp-doc-reviewers> @KseniyaTikhomirova<https://github.com/KseniyaTikhomirova> for reachability since it has been open for a couple of days now.
hello, it has ci failures, that seems to be related.
—
Reply to this email directly, view it on GitHub<#7309 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A3A4DXUUB7T4GPW7B5U4LS3WHURBDANCNFSM6AAAAAARZXOSEY>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
pvchupin
approved these changes
Nov 10, 2022
Contributor
|
SYCL :: Basic/barrier_order.cpp test on HIP is disabled at intel/llvm-test-suite#1375 |
pvchupin
pushed a commit
that referenced
this pull request
Nov 11, 2022
#7309 post-commit failure fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add support for negative filters for the ONEAPI_DEVICE_SELECTOR variable to provide the user with a more flexible way of specifying which devices should and should not be available for usage. For example, ONEAPI_DEVICE_SELECTOR='opencl:*;!opencl:gpu' considers all opencl backend devices except for those that are of the gpu type.