[ESIMD] Fix specialization/instantiation order in traits infra. #6677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to avoid errors on Linux, where compiler picks up instatiation of wrong specialization of elem_type_traits (the default unusable one) when instatiating __raw_t alias. Also do not use specialization of elem_type_traits (e.g. __raw_t) when definition of the trait is not complete. Make WrapperElementTypeProxy specific to sycl::half trait, because it won't be needed for other types traits.
v-klochkov
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to avoid errors on Linux, where compiler picks up
instatiation of wrong specialization of elem_type_traits (the default
unusable one) when instatiating __raw_t alias.
Also do not use specialization of elem_type_traits (e.g. __raw_t) when
definition of the trait is not complete.
Make WrapperElementTypeProxy specific to sycl::half trait, because it
won't be needed for other types traits.