[Driver][SYCL] Add support for -fsycl-force-target #6653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce -fsycl-force-target=arg support. This is used along with -fsycl to allow the user to override the target used to unbundle device objects from fat objects and archives. For example, object.o is built from -fsycl-targets=spir64. The user wants to build with -fsycl-targets=spir64_gen and object.o. Use of -fsycl-force-target=spir64 allows for this to be accomplished. Additional notes: - Only valid when used with a single triple from -fsycl-targets - Applies to all unbundled archives and objects
premanandrao
previously approved these changes
Aug 29, 2022
Contributor
premanandrao
left a comment
premanandrao
left a comment
There was a problem hiding this comment.
I expect the Driver team to review this more thoroughly, but the FE changes look okay to me.
elizabethandrews
previously approved these changes
Aug 29, 2022
Contributor
elizabethandrews
left a comment
elizabethandrews
left a comment
There was a problem hiding this comment.
FE changes LGTM
hchilama
previously approved these changes
Aug 29, 2022
Contributor
Author
|
@intel/dpcpp-doc-reviewers, can you take a look? |
mdtoguchi
dismissed stale reviews from hchilama, elizabethandrews, and premanandrao
via
037d753
mdtoguchi
requested review from
elizabethandrews,
hchilama,
premanandrao and
steffenlarsen
elizabethandrews
approved these changes
Aug 30, 2022
steffenlarsen
approved these changes
Aug 31, 2022
Contributor
steffenlarsen
left a comment
steffenlarsen
left a comment
There was a problem hiding this comment.
LGTM. Reviewing for @intel/dpcpp-doc-reviewers .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce -fsycl-force-target=arg support. This is used along with -fsycl
to allow the user to override the target used to unbundle device objects
from fat objects and archives.
For example, object.o is built from -fsycl-targets=spir64. The user wants
to build with -fsycl-targets=spir64_gen and object.o. Use of
-fsycl-force-target=spir64 allows for this to be accomplished.
Additional notes: