[SYCL][CUDA] Ignore and warn for mem-advise when requirement not met #6281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to cuMemPrefetchAsync, cuMemAdvise may require that a device supports concurrent managed memory access. These changes makes cuda_piextUSMEnqueueMemAdvise ignore and warn when a number of memory advises if the device does not meet the aforementioned requirement. Signed-off-by: Larsen, Steffen <[email protected]>
AidanBeltonS
previously approved these changes
Jun 9, 2022
Contributor
AidanBeltonS
left a comment
AidanBeltonS
left a comment
There was a problem hiding this comment.
LGTM! Prefetch looks much cleaner
Signed-off-by: Larsen, Steffen <[email protected]>
smaslov-intel
approved these changes
Jun 9, 2022
steffenlarsen
deleted the
steffen/cuda_memadvise_conc_managed_access_req
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to cuMemPrefetchAsync, cuMemAdvise may require that a device supports concurrent managed memory access. These changes makes cuda_piextUSMEnqueueMemAdvise ignore and warn for a number of memory advises if the device does not meet the aforementioned requirement.