Skip to content

[SYCL][L0] Remove unused argument from piQueueReleaseInternal #6226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

steffenlarsen
Copy link
Contributor

#6192 removed the need for the LockedQueue parameter in piQueueReleaseInternal. These changes remove the parameter from the function.

intel#6192 removed the need for the
LockedQueue parameter in piQueueReleaseInternal. These changes remove
the parameter from the function.

Signed-off-by: Larsen, Steffen <[email protected]>
@steffenlarsen steffenlarsen requested a review from a team as a code owner June 1, 2022 12:04
Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@againull : please see if we can also remove the LockedQueue from the EventRelease function.

@againull
Copy link
Contributor

againull commented Jun 1, 2022

Sorry, this change was merged in scope of #6179. I have to close this one. Aforementioned PR additionally removes the LockedQueue from the EventRelease.

@againull againull closed this Jun 1, 2022
@againull
Copy link
Contributor

againull commented Jun 1, 2022

LGTM.

@againull : please see if we can also remove the LockedQueue from the EventRelease function.

Yes, it is removed in scope of #6179

@steffenlarsen steffenlarsen deleted the steffen/6192_fix_unused_var branch December 6, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants