Skip to content

[SYCL][FPGA] Update [[intel::max_concurrency()]] attribute support #6126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 23, 2022
Merged

[SYCL][FPGA] Update [[intel::max_concurrency()]] attribute support #6126

merged 7 commits into from
May 23, 2022

Conversation

smanna12
Copy link
Contributor

@smanna12 smanna12 commented May 9, 2022 •
edited
Loading

This patch improves support for [[intel::max_concurrency()]] implementation.

  1. Fixes bugs the way attribute handled duplicate attribute diagnostics.
  2. Adds missing diagnostics test cases.
  3. Splits AST and diagnostics part for better codes readability(part of [SYCL] Split diagnostic and AST parts for sema tests. #4118).

Signed-off-by: Soumi Manna [email protected]

smanna12 added 5 commits May 9, 2022 09:08
@smanna12
[SYCL][FPGA] Update [[intel::max_concurrency()]] attribute support
819429f 
Signed-off-by: Soumi Manna <[email protected]>
@smanna12
Fix format errors
37f5cf1 
Signed-off-by: Soumi Manna <[email protected]>
@smanna12
Fix format errors
d6878b1 
Signed-off-by: Soumi Manna <[email protected]>
@smanna12
update patch
65e4b3c 
Signed-off-by: Soumi Manna <[email protected]>
@smanna12
fix format errors
21221b5 
Signed-off-by: Soumi Manna <[email protected]>
@smanna12 smanna12 marked this pull request as ready for review May 9, 2022 17:01
@smanna12 smanna12 requested a review from a team as a code owner May 9, 2022 17:01
@smanna12 smanna12 requested a review from AaronBallman May 9, 2022 17:01
AaronBallman
AaronBallman reviewed May 9, 2022
View reviewed changes
Copy link
Contributor

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attribute changes look reasonable to me, but I'll leave it to someone else for the final sign-off.

premanandrao
premanandrao previously approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smanna12
Copy link
Contributor Author

smanna12 commented May 9, 2022

Than you for reviews.

@smanna12
Copy link
Contributor Author

smanna12 commented May 9, 2022 •
edited
Loading

@intel/llvm-gatekeepers, this PR is ready to be merged. Thank you

The failure does not seem related to my PR:
http://icl-jenkins.sc.intel.com:8080/blue/organizations/jenkins/SYCL_CI%2Fintel%2FLin%2FBasic_E2E/detail/Basic_E2E/2517/pipeline

Failed Tests (1):
SYCL :: Basic/queue/release.cpp

elizabethandrews
elizabethandrews reviewed May 10, 2022
View reviewed changes
elizabethandrews
elizabethandrews reviewed May 10, 2022
View reviewed changes
@pvchupin
Copy link
Contributor

@smanna12 can you please sync with @elizabethandrews on recent concerns?

elizabethandrews
elizabethandrews reviewed May 10, 2022
View reviewed changes
elizabethandrews
elizabethandrews approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@elizabethandrews elizabethandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@smanna12
Copy link
Contributor Author

smanna12 commented May 23, 2022 •
edited
Loading

The failures are not related to my change:
https://github.com/intel/llvm/runs/6557758043?check_suite_focus=true

The same failures are happening with other PR's also.
Failed Tests (6):
SYCL :: GroupAlgorithm/SYCL2020/exclusive_scan.cpp
SYCL :: GroupAlgorithm/SYCL2020/inclusive_scan.cpp
SYCL :: GroupAlgorithm/SYCL2020/reduce.cpp
SYCL :: GroupAlgorithm/exclusive_scan.cpp
SYCL :: GroupAlgorithm/inclusive_scan.cpp
SYCL :: GroupAlgorithm/reduce.cpp

@smanna12
Copy link
Contributor Author

Thank you for the reviews.

@smanna12
Copy link
Contributor Author

@intel/llvm-gatekeepers, this PR is ready to be merged. Thank you

@pvchupin
Copy link
Contributor

Fails are handled at intel/llvm-test-suite#1034

@pvchupin pvchupin merged commit b6aa4cc into intel:sycl May 23, 2022
@smanna12 smanna12 deleted the updatestests branch May 23, 2022 19:11
yinyangsx pushed a commit to yinyangsx/llvm that referenced this pull request May 25, 2022
@smanna12
[SYCL][FPGA] Update [[intel::max_concurrency()]] attribute support (i…
3bf37d5 
…ntel#6126)

This patch improves support for [[intel::max_concurrency()]] implementation.

Fixes bugs the way attribute handled duplicate attribute diagnostics.
Adds missing diagnostics test cases.
Splits AST and diagnostics part for better codes readability(part of [SYCL] Split diagnostic and AST parts for sema tests. intel#4118).

Signed-off-by: Soumi Manna [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronBallman AaronBallman AaronBallman left review comments

@elizabethandrews elizabethandrews elizabethandrews approved these changes

@premanandrao premanandrao Awaiting requested review from premanandrao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smanna12 @pvchupin @AaronBallman @premanandrao @elizabethandrews