[SYCL] Fix piextProgramSetSpecializationConstant usage #6125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This entry point is only meant to be called when native specialization constants are supported, so AOT only targets don't support it. Still implement it in the AOT only plugins to have clearer error if it's accidentally called.
|
Please add a comment to function definition that it is only supported for SPIR-V programs. llvm/sycl/include/CL/sycl/detail/pi.h Line 1291 in f232cfd |
smaslov-intel
approved these changes
May 12, 2022
pvchupin
pushed a commit
that referenced
this pull request
May 19, 2022
This patch solves #6093, and finishes to fix #5911 It doesn't change anything for native specialization constants, but correctly aligns emulated specialization constants based on type requirements. Emulated specialization constant don't use the CompositeOffset mechanism, so this patch re-uses this field to communicate the necessary padding from the compiler pass in sycl-post-link to the runtime to ensure correct alignment. With this patch the SYCL-CTS specialization constant tests are all passing with the CUDA plugin: % ./bin/test_specialization_constants ======================= All tests passed (56 assertions in 46 test cases) Note this is on top of #6125
yinyangsx
pushed a commit
to yinyangsx/llvm
that referenced
this pull request
May 25, 2022
This patch solves intel#6093, and finishes to fix intel#5911 It doesn't change anything for native specialization constants, but correctly aligns emulated specialization constants based on type requirements. Emulated specialization constant don't use the CompositeOffset mechanism, so this patch re-uses this field to communicate the necessary padding from the compiler pass in sycl-post-link to the runtime to ensure correct alignment. With this patch the SYCL-CTS specialization constant tests are all passing with the CUDA plugin: % ./bin/test_specialization_constants ======================= All tests passed (56 assertions in 46 test cases) Note this is on top of intel#6125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This entry point is only meant to be called when native specialization
constants are supported, so AOT only targets don't support it.
Still implement it in the AOT only plugins to have clearer error if it's
accidentally called.
This is mentioned in #6093, although it doesn't touch the alignment issue.