Skip to content

[SYCL] Emit llvm.compiler.used for internal device globals #5958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 18, 2022
Merged

[SYCL] Emit llvm.compiler.used for internal device globals #5958

merged 3 commits into from
Aug 18, 2022

Conversation

@Fznamznon
Copy link
Contributor

@Fznamznon Fznamznon commented Apr 4, 2022

This prevents early optimizations from removing device globals with
internal linkage.

@Fznamznon
[SYCL] Emit llvm.compiler.used for internal device globals
6eda0c7 
This prevents early optimizations from removing device globals with
internal linkage.
@Fznamznon Fznamznon requested a review from a team as a code owner April 4, 2022 14:31
@Fznamznon Fznamznon requested a review from steffenlarsen April 4, 2022 14:31
@Fznamznon
Copy link
Contributor Author

Fznamznon commented Apr 4, 2022

This doesn't fully fix device globals with internal linkage because early optimizations break address spaces.

premanandrao
premanandrao previously approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay to me.

smanna12
smanna12 reviewed Apr 4, 2022
View reviewed changes
steffenlarsen
steffenlarsen previously approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

smanna12
smanna12 previously approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@smanna12 smanna12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

premanandrao
premanandrao previously approved these changes Apr 5, 2022
View reviewed changes
steffenlarsen
steffenlarsen approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Fznamznon
Copy link
Contributor Author

Fznamznon commented Aug 17, 2022

The following failures in OCL x64 LLVM Test Suite (pull_request_target) test run look like a common problem and therefore unrelated to this PR:

********************
Failed Tests (1):
  SYCL :: XPTI/kernel/content.cpp

********************
Unexpectedly Passed Tests (2):

  SYCL :: SubGroup/reduce_spirv13.cpp
  SYCL :: SubGroup/reduce_spirv13_fp64.cpp
2 warning(s) in tests

@Fznamznon
Copy link
Contributor Author

Fznamznon commented Aug 18, 2022

@intel/llvm-gatekeepers , I believe this one is ready for merge.

@steffenlarsen steffenlarsen merged commit 5b2cfe2 into intel:sycl Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elizabethandrews elizabethandrews elizabethandrews approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@premanandrao premanandrao Awaiting requested review from premanandrao

+1 more reviewer

@smanna12 smanna12 smanna12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Fznamznon @premanandrao @elizabethandrews @smanna12 @steffenlarsen