Skip to content

[SYCL][Matrix] Add more operators for wi_element #5270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2022
Merged

[SYCL][Matrix] Add more operators for wi_element #5270

merged 2 commits into from
Jan 10, 2022

Conversation

yubingex007-a11y
Copy link
Contributor

@yubingex007-a11y yubingex007-a11y commented Jan 7, 2022 •
edited
Loading

  1. We add binary operators: +, -, *, /=, and binary assignment operators
    +=, -=, /=
  2. Add support for logical operators: >, >=, <, <=, ==, !=
  3. Add support for explicit operator bool()

@yubingex007-a11y yubingex007-a11y requested a review from a team as a code owner January 7, 2022 06:04
dkhaldi
dkhaldi previously approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but just add a description that this is a continuation to the merged patch that adds more operator overloading to enable element wise operations for joint_matrix

@yubingex007-a11y
[SYCL][Matrix] Add more operators for wi_element
642575a 
1. We add binary operators: +, -, *, /=, and binary assignment operators
+=, -=, /=
2. Add support for logical operators: >, >=, <, <=, ==, !=
3. Add support for explicit operator bool()
steffenlarsen
steffenlarsen reviewed Jan 7, 2022
View reviewed changes
@yubingex007-a11y
Copy link
Contributor Author

@intel/llvm-reviewers-runtime ping?

@yubingex007-a11y yubingex007-a11y requested a review from a team January 7, 2022 16:50
steffenlarsen
steffenlarsen approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yubingex007-a11y
Copy link
Contributor Author

@intel/llvm-reviewers-runtime ping?

@vladimirlaz vladimirlaz merged commit fe2e35e into intel:sycl Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhaldi dkhaldi dkhaldi approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@AlexeySotkin AlexeySotkin Awaiting requested review from AlexeySotkin

@MrSidims MrSidims Awaiting requested review from MrSidims

@LuoYuanke LuoYuanke Awaiting requested review from LuoYuanke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yubingex007-a11y @dkhaldi @steffenlarsen @vladimirlaz