[SYCL] Remove handler::codeplay_host_task #4426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mdimakov <[email protected]>
Signed-off-by: mdimakov <[email protected]>
maximdimakov
changed the title
This was referenced Aug 30, 2021
againull
reviewed
Aug 30, 2021
Contributor
againull
left a comment
againull
left a comment
There was a problem hiding this comment.
Could you please fix unittests/scheduler/InOrderQueueHostTaskDeps.cpp unit test.
Contributor
Author
againull
previously approved these changes
Aug 31, 2021
bader
changed the title
romanovvlad
approved these changes
Sep 9, 2021
DoyleLi
pushed a commit
to DoyleLi/intel_llvm
that referenced
this pull request
Sep 13, 2021
handler::codeplay_host_task is deprecated in SYCL 2020. This patch depends on : Changes in Lit Tests : intel/llvm-test-suite#428 and intel/llvm-test-suite#451 Signed-off-by: mdimakov [email protected]
npmiller
added a commit
to npmiller/oneMKL
that referenced
this pull request
Oct 20, 2021
`codeplay_host_task` is deprecated in SYCL 2020, `host_task` should be used instead, this is already what is used by the cublas backend. Additionally support for `codeplay_host_task` was recently removed from DPC++, intel/llvm#4426 so this code wouldn't build with recent DPC++.
mkrainiuk
pushed a commit
to uxlfoundation/oneMath
that referenced
this pull request
Oct 22, 2021
`codeplay_host_task` is deprecated in SYCL 2020, `host_task` should be used instead, this is already what is used by the cublas backend. Additionally support for `codeplay_host_task` was recently removed from DPC++, intel/llvm#4426 so this code wouldn't build with recent DPC++.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handler::codeplay_host_task is deprecated in SYCL 2020.
This patch depends on :
Changes in Lit Tests : intel/llvm-test-suite#428 and intel/llvm-test-suite#451
Signed-off-by: mdimakov [email protected]