[SYCL] Support reqd_work_group_size for SYCL #429
Conversation
Signed-off-by: Andrew Savonichev <[email protected]>
| // attribute must never appear as a group" for attributes like cold and hot. | ||
| if (!D->hasAttr<OpenCLKernelAttr>()) { | ||
| if (!(D->hasAttr<OpenCLKernelAttr>() || | ||
| LangOpts.SYCLIsDevice || LangOpts.SYCLIsHost)) { |
There was a problem hiding this comment.
LangOpts.SYCLIsHost variables name suggests that it's true for the host side of the SYCL application.
Could you clarify what should happen with this attribute on the host side? How will handle it?
There was a problem hiding this comment.
LangOpts.SYCLIsHost variables name suggests that it's true for the host side of the SYCL application.
Correct.
Could you clarify what should happen with this attribute on the host side? How will handle it?
The reason I did this was to avoid a diagnostic about unsupported attributes for host compilation. Since I didn't do anything to drop the attribute, it is probably emitted to LLVM IR (and ignored by optimizations & codegen) for host code.
There was a problem hiding this comment.
This is actually re-using of solution developed in #296
There was a problem hiding this comment.
AFAIK this attribute cannot be ignored, so we need somehow handle it when executing on host device.
CONFLICT (content): Merge conflict in clang/include/clang/Driver/Options.td
4 participants
Signed-off-by: Andrew Savonichev [email protected]