Skip to content

[SYCL] Revert barrier deprecation note #4162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2021
Merged

[SYCL] Revert barrier deprecation note #4162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sycl/include/CL/sycl/nd_item.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ template <int dimensions = 1> class nd_item {
get_offset());
}

__SYCL2020_DEPRECATED("use sycl::group_barrier() free function instead")
void barrier(access::fence_space accessSpace =
access::fence_space::global_and_local) const {
uint32_t flags = detail::getSPIRVMemorySemanticsMask(accessSpace);
Expand Down
2 changes: 0 additions & 2 deletions sycl/test/warnings/sycl_2020_deprecations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@ int main() {
CGH.parallel_for<class Test>(
sycl::nd_range<1>{sycl::range{10}, sycl::range{10}, sycl::range{1}},
[](sycl::nd_item<1> it) {
// expected-warning@+1{{'barrier' is deprecated: use sycl::group_barrier() free function instead}}
it.barrier();
// expected-warning@+2{{'mem_fence' is deprecated: use sycl::group_barrier() free function instead}}
// expected-warning@+1{{'mem_fence<sycl::access::mode::read_write>' is deprecated: use sycl::group_barrier() free function instead}}
it.mem_fence();
Expand Down