[SYCL] Fix passing extra clang flags to lit tests #4110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CFLAGS` is a `make` environment variable so its contents were not used by the lit tests which call `clang` directly. Adding them to the `additional_flags` of `use_clang`, adds them to the `%clangxx` substitutions and ensures they are passed around everywhere. In addition these extra flags were only set on Linux because they were used for Linux C++ library assertions, but now they will be set on both Linux and Windows, however the Linux C++ library assertions defines will only be set on Linux. This also allows users to add custom clang parameters to the lit tests through the `SYCL_CLANG_EXTRA_FLAGS` CMake parameter. Which will be a requirement for the ROCm AMD lit tests as for AMD the target needs to be specified with `-mcpu`.
Contributor
|
@erichkeane: FYI, |
sergey-semenov
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CFLAGSis amakeenvironment variable so its contents were not usedby the lit tests which call
clangdirectly.Adding them to the
additional_flagsofuse_clang, adds them to the%clangxxsubstitutions and ensures they are passed around everywhere.In addition these extra flags were only set on Linux because they were
used for Linux C++ library assertions, but now they will be set on both
Linux and Windows, however the Linux C++ library assertions defines will
only be set on Linux.
This also allows users to add custom clang parameters to the lit tests
through the
SYCL_CLANG_EXTRA_FLAGSCMake parameter. Which will be arequirement for the ROCm AMD lit tests as for AMD the target needs to be
specified with
-mcpu.