[ESIMD] Don't invoke sycl-post-link in clang tests #3651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisBakhvalov
requested review from
AaronBallman,
elizabethandrews and
premanandrao
as code owners
kbobrovs
reviewed
Apr 29, 2021
| // kernels: | ||
| // - Proper 'kernel_arg_accessor_ptr' metadata is generated by the FE for | ||
| // ESIMD kernels | ||
| // - Pointers originating from accessors are marked with 'buffer_t' and proper |
There was a problem hiding this comment.
Are we just simply removing the checks from here w/o reproducing them elsewhere (e.g. in new LowerESIMD tests)?
There was a problem hiding this comment.
No, there are existing tests on LowerESIMD pass that check that. I mentioned this in the commit message.
kbobrovs
approved these changes
Apr 29, 2021
| // kernels: | ||
| // - Proper 'kernel_arg_accessor_ptr' metadata is generated by the FE for | ||
| // ESIMD kernels | ||
| // - Pointers originating from accessors are marked with 'buffer_t' and proper |
bader
approved these changes
Apr 29, 2021
|
@AaronBallman, @elizabethandrews, @premanandrao, ping. |
AaronBallman
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3629.
Removed checks are performed in other places: in llvm and llvm-spirv components.