[SYCL][NFC] Updates CodeGen codes for function attributes #3637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need for a dyn_cast<> followed by an assert. This patch adds cast<> instead for attributes below: SYCLIntelNoGlobalWorkOffsetAttr SYCLIntelMaxGlobalWorkDimAttr SYCLIntelNumSimdWorkItemsAttr ReqSubGroup Signed-off-by: Soumi Manna <[email protected]>
smanna12
requested review from
AaronBallman,
elizabethandrews and
premanandrao
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds cast<> instead of dyn_cast<> + assert() and
auto instead of Attribute Name for SYCL function attributes below:
SYCLIntelNoGlobalWorkOffsetAttr
SYCLIntelMaxGlobalWorkDimAttr
SYCLIntelNumSimdWorkItemsAttr
SYCLIntelSchedulerTargetFmaxMhzAttr
IntelReqdSubGroupSizeAttr
Signed-off-by: Soumi Manna [email protected]