[CUDA][NFC] Refactor CUDA-specific passes to work with new pass manager #3264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored GlobalOffset pass to use new pass manager interface and added a wrapper to use it with the legacy pass manager. At the moment this is a non-functional change, because CodeGen passes are still scheduled through the legacy pass manager and some additional changes will be needed to include the pass into a pipeline when it will be composed using the new pass manager.
Refactored LocalAccessorToSharedMemory pass to use new pass manager interface and added a wrapper to use it with the legacy pass manager. At the moment this is a non-functional change, because CodeGen passes are still scheduled through the legacy pass manager and some additional changes will be needed to include the pass into a pipeline when it will be composed using the new pass manager.
|
Tagging @Alexander-Johnston and @steffenlarsen for awareness as well |
bader
changed the title
|
Please, fix CI checks. |
and merge conflicts. |
|
@mlychkov, @AlexeySachkov, should we close this PR? |
|
@bader, those passes are still using legacy pass manager interface, but at the same time, my understanding is that llvm CodeGen has not yet migrated to a new pass manager, meaning that updating of this passes is not so important at the moment. Let's close this PR as I don't work on it actively anyway |
vmaksimo
pushed a commit
that referenced
this pull request
Jul 29, 2025
There's no SPIRV translation for `llvm.fake.use`, and currently it's causing the translator to crash, so just ignore it to prevent crashes. Original commit: KhronosGroup/SPIRV-LLVM-Translator@daada5684da36fd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.