[ESIMD] Remove propagation of sycl_explicit_simd to the callees #3152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisBakhvalov
requested review from
elizabethandrews and
premanandrao
as code owners
Fznamznon
approved these changes
Feb 3, 2021
DenisBakhvalov
changed the title
Contributor
Another important reason why we no longer need sycl_explicit_simd at every function in the call graph is that we decided that callgraph traversal and SYCL-ESIMD split will now be done in sycl-post-link rather than FE. |
kbobrovs
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to mark the ESIMD CFG since all ESIMD-specific passes will work exclusively on the ESIMD code. So, in ESIMD passes we don't have to worry about breaking other SYCL code.