[Driver][SYCL] Fix SYCL option passing for preprocessing #3149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing SYCL offload, various -fsycl -fsycl-is* options are passed to the host and target compilations respectively. When performing preprocessing, a few of these options were not properly passed causing problems with the generated preprocessed file for the host compilation side.
AGindinson
previously approved these changes
Feb 3, 2021
AGindinson
approved these changes
Feb 3, 2021
jsji
pushed a commit
that referenced
this pull request
May 30, 2025
The std::memory_order enum gets changed in C++20: https://en.cppreference.com/w/cpp/atomic/memory_order This change makes OCLUtil.h includable by projects that use C++20. Original commit: KhronosGroup/SPIRV-LLVM-Translator@61303255b75bb23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing SYCL offload, various -fsycl -fsycl-is* options are passed
to the host and target compilations respectively. When performing
preprocessing, a few of these options were not properly passed causing
problems with the generated preprocessed file for the host compilation
side.