[SYCL] Merge two set_final_data methods into one #3140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mdimakov <[email protected]>
Signed-off-by: mdimakov <[email protected]>
Signed-off-by: mdimakov <[email protected]>
Signed-off-by: mdimakov <[email protected]>
Signed-off-by: mdimakov <[email protected]>
Signed-off-by: mdimakov <[email protected]>
Signed-off-by: mdimakov <[email protected]>
Signed-off-by: mdimakov <[email protected]>
Signed-off-by: mdimakov <[email protected]>
Signed-off-by: mdimakov <[email protected]>
romanovvlad
reviewed
Feb 2, 2021
Contributor
romanovvlad
left a comment
romanovvlad
left a comment
There was a problem hiding this comment.
LGTM, but would like @s-kanaev to approve.
s-kanaev
suggested changes
Feb 2, 2021
Contributor
s-kanaev
left a comment
s-kanaev
left a comment
There was a problem hiding this comment.
The change looks good. Though, a TODO is to be preserved.
s-kanaev
changed the title
s-kanaev
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up after #3099. To simplify the code it was decided to merge two set_final_data methods.