[SYCL] Join thread pool threads on Scheduler destruction #3090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Threads from default queue thread pool can access scheduler after its destruction has begun. To avoid such illegal access, wait for all threads to join in scheduler destructor.
romanovvlad
previously approved these changes
Jan 25, 2021
s-kanaev
previously approved these changes
Jan 26, 2021
alexbatashev
dismissed stale reviews from s-kanaev and romanovvlad
via
ba3fbc0
s-kanaev
approved these changes
Feb 3, 2021
vladimirlaz
pushed a commit
to vladimirlaz/llvm
that referenced
this pull request
Mar 26, 2021
Threads from default queue thread pool can access scheduler after its destruction has begun. To avoid such illegal access, wait for all threads to join in scheduler destructor.
vladimirlaz
added a commit
that referenced
this pull request
Mar 26, 2021
Threads from default queue thread pool can access scheduler after its destruction has begun. To avoid such illegal access, wait for all threads to join in scheduler destructor. Co-authored-by: Alexander Batashev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Threads from default queue thread pool can access scheduler after its destruction has begun.
To avoid such illegal access, wait for all threads to join in scheduler destructor.