[SYCL][ESIMD] always set up fence before barrier as required by HW #3083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmc-rep
force-pushed
the
cmc-rep-change
branch
from
3a726f1 to
b85e454
Compare
kbobrovs
reviewed
Jan 26, 2021
Contributor
kbobrovs
left a comment
kbobrovs
left a comment
There was a problem hiding this comment.
Absence of __esimd_slm_fence should have caused some of ESIMD tests to fail. @cmc-rep - could you please add such test into llvm-test-suite?
Please also add more detailed description of the semantics of esimd_barrier so that it appears in the html docs.
Signed-off-by: Gang Y Chen <[email protected]>
cmc-rep
force-pushed
the
cmc-rep-change
branch
from
b85e454 to
f280346
Compare
Contributor
|
@cmc-rep, friendly ping |
kbobrovs
approved these changes
Feb 5, 2021
Contributor
kbobrovs
left a comment
kbobrovs
left a comment
There was a problem hiding this comment.
Thanks. As we talked elsewhere, the test is not possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gang Y Chen [email protected]