Skip to content

Conversation

@elizabethandrews
Copy link
Contributor

Add predefined macro __DPCPP_COMPILER = 1, to uniquely identify DPCPP compiler.

Signed-off-by: Elizabeth Andrews [email protected]

Signed-off-by: Elizabeth Andrews <[email protected]>
Copy link
Contributor

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the assumption that we don't need the feature-testing components because it will be handled through other means, this LGTM

Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the review @AaronBallman

@elizabethandrews
Copy link
Contributor Author

Thanks @AaronBallman and @premanandrao!

@pvchupin is there a known failure with pre-commit testing? There is a stream test failing. I do not know how this change can cause it.

@premanandrao
Copy link
Contributor

@pvchupin is there a known failure with pre-commit testing? There is a stream test failing. I do not know how this change can cause it.

@pvchupin thinks it is a flaky failure, in #2967

Copy link
Contributor

@pvchupin pvchupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss more on this macro first.

@bader
Copy link
Contributor

bader commented Feb 12, 2021

Let's discuss more on this macro first.

Any updates on this?

@elizabethandrews
Copy link
Contributor Author

Let's discuss more on this macro first.

Any updates on this?

After an offline discussion with @pvchupin and others, a decision was made to not support any additional macros at the moment. SYCL_LANGUAGE_VERSION can be used to identify any SYCL compiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants