[SYCL] Remove redundant event dependencies for in-order queues #2929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid passing explicit dependencies on events from the same in-order queue since the order of execution is already guaranteed in that case.
s-kanaev
reviewed
Dec 22, 2020
Contributor
s-kanaev
left a comment
s-kanaev
left a comment
There was a problem hiding this comment.
Question: is there any corner case when alloca command isn't present in dependencies of dependent command?
romanovvlad
reviewed
Dec 22, 2020
s-kanaev
previously approved these changes
Dec 22, 2020
s-kanaev
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid passing explicit dependencies on events from the same in-order
queue since the order of execution is already guaranteed in that case.