Skip to content

[SYCL] Fix SIGKILL after setting large WG sizes #2641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2020
Merged

[SYCL] Fix SIGKILL after setting large WG sizes #2641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions sycl/source/detail/scheduler/commands.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1620,20 +1620,7 @@ static void adjustNDRangePerKernel(NDRDescT &NDR, RT::PiKernel Kernel,
get(Kernel, DeviceImpl.getHandleRef(), DeviceImpl.getPlugin());

if (WGSize[0] == 0) {
// kernel does not request specific workgroup shape - set one
id<3> MaxWGSizes =
get_device_info<id<3>, cl::sycl::info::device::max_work_item_sizes>::
get(DeviceImpl.getHandleRef(), DeviceImpl.getPlugin());

size_t WGSize1D = get_kernel_device_specific_info<
size_t, cl::sycl::info::kernel_device_specific::work_group_size>::
get(Kernel, DeviceImpl.getHandleRef(), DeviceImpl.getPlugin());

assert(MaxWGSizes[2] != 0);

// Set default work-group size in the Z-direction to either the max
// number of work-items or the maximum work-group size in the Z-direction.
WGSize = {1, 1, min(WGSize1D, MaxWGSizes[2])};
WGSize = {1, 1, 1};
}
NDR.set(NDR.Dims, nd_range<3>(NDR.NumWorkGroups * WGSize, WGSize));
}
Expand Down