[SYCL] Emit kernel args size warning for real sycl headers #2554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turned out that real sycl headers are included as "system" headers and the actual warning points to function defined there, so the warning about kernel arguments size wasn't emitted.
Fznamznon
requested review from
a team,
elizabethandrews and
premanandrao
as code owners
Fznamznon
commented
Sep 28, 2020
alexbatashev
previously approved these changes
Sep 28, 2020
elizabethandrews
previously approved these changes
Sep 28, 2020
Co-authored-by: Mariya Podchishchaeva <[email protected]>
bader
dismissed stale reviews from elizabethandrews, alexbatashev, and premanandrao
via
b618f01
alexbatashev
approved these changes
Sep 29, 2020
iclsrc
pushed a commit
that referenced
this pull request
May 9, 2024
After LLVM commit 91446e2 ("Repply#2 "[RemoveDIs] Load into new debug info format by default in LLVM (#89799)"", 2024-05-03), we need to disable the new debug record format explicitly until we have migrated to the new format. Original commit: KhronosGroup/SPIRV-LLVM-Translator@8878e7bfddbe2cb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out that real sycl headers are included as "system" headers
and the actual warning points to function defined there, so the warning
about kernel arguments size wasn't emitted.