[SYCL][Driver][NFC] Address klockwork issues #2496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meghana Thatishetti <[email protected]>
meghanathatishetti
requested review from
AGindinson and
mdtoguchi
as code owners
Signed-off-by: Meghana Thatishetti <[email protected]>
mdtoguchi
reviewed
Sep 18, 2020
Comment on lines
1259
to
1261
| if (!XOffloadTargetArg) | ||
| XOffloadTargetArg->setBaseArg(A); | ||
|
|
There was a problem hiding this comment.
Suggested change
| if (!XOffloadTargetArg) | |
| XOffloadTargetArg->setBaseArg(A); | |
| if (!XOffloadTargetArg) | |
| continue; |
if there is no XOffloadTargetArg, we don't want to set the base arg or release (nothing to release).
kbenzie
added a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
[UR][Bindless] Initial implementation of bindless images for HIP
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
[UR][Bindless] Initial implementation of bindless images for HIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Meghana Thatishetti [email protected]