[SYCL] Re-implement warning that checks number of arguments #2420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GPU has limitation on size of kernel aguments, not number.
Fznamznon
requested review from
elizabethandrews and
premanandrao
as code owners
Contributor
|
I suggest we rename clang/test/SemaSYCL/num-args-overflow.cpp test. |
premanandrao
reviewed
Sep 3, 2020
Contributor
premanandrao
left a comment
premanandrao
left a comment
There was a problem hiding this comment.
But otherwise, looks okay to me.
premanandrao
reviewed
Sep 3, 2020
Contributor
elizabethandrews
left a comment
elizabethandrews
left a comment
There was a problem hiding this comment.
LGTM other than the unnecessary 'note'
premanandrao
approved these changes
Sep 3, 2020
jsji
pushed a commit
that referenced
this pull request
Mar 26, 2024
* Update magic value used in named sub group size extension * Remove print Original commit: KhronosGroup/SPIRV-LLVM-Translator@e8e06667df8f5f5
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
…rted-feature [DevAsan] Report error when using unsupported extension API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPU has limitation on size of kernel aguments, not number.