Revert "[InstCombine] Always try to invert non-canonical predicate of… #2384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeySotkin
requested review from
Fznamznon,
bader,
elizabethandrews and
premanandrao
as code owners
… an icmp" This reverts commit c3b8bd1. Alse adjust a couple of Clang LIT tests. Signed-off-by: Alexey Sotkin <[email protected]>
AlexeySotkin
force-pushed
the
revert-icmp-predicate
branch
from
242676a to
2a24e6b
Compare
Contributor
|
What is the reason for this revert? |
Contributor
Author
In some cases canonicalization of |
Contributor
|
It sounds like an issue, which should be addressed by the back end compiler. |
Contributor
|
/summary:run |
Contributor
Author
Thanks! |
Contributor
|
@AlexeySotkin, are still going to commit this change? |
Contributor
Author
No. |
jsji
pushed a commit
that referenced
this pull request
Mar 7, 2024
This patch fixes verification of Get/Async Capacity literals making translator accept zero values which are valid by spec. Original commit: KhronosGroup/SPIRV-LLVM-Translator@22f9e3e67b36b36
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Failing e2e tests no longer kill the whole build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… an icmp"
This reverts commit c3b8bd1.
Alse adjust a couple of Clang LIT tests.
Signed-off-by: Alexey Sotkin [email protected]