Skip to content

[SYCL CI][Linux GPU RT Uplift] Uplift GPU RT version for Linux CI Process #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2020
Merged

[SYCL CI][Linux GPU RT Uplift] Uplift GPU RT version for Linux CI Process #2374

merged 1 commit into from
Aug 31, 2020

Conversation

@bb-sycl
Copy link
Contributor

@bb-sycl bb-sycl commented Aug 26, 2020

Uplift GPU RT version for Linux to 20.33.17675

@bb-sycl bb-sycl requested a review from bader as a code owner August 26, 2020 14:14
@bader
Copy link
Contributor

bader commented Aug 26, 2020

/summary:run

@yinyangsx yinyangsx requested a review from vladimirlaz August 27, 2020 01:49
@yinyangsx
Copy link

yinyangsx commented Aug 27, 2020 •
edited
Loading

It looks like this uplifting causes CUDA driver in 'ERR' state, we can see the error state in next build. http://ci.llvm.intel.com:8010/#/builders/37/builds/2786. @vladimirlaz, could you please have a look?

+-----------------------------------------------------------------------------+
| NVIDIA-SMI 435.21 Driver Version: 435.21 CUDA Version: 10.1 |
|-------------------------------+----------------------+----------------------+
| GPU Name Persistence-M| Bus-Id Disp.A | Volatile Uncorr. ECC |
| Fan Temp Perf Pwr:Usage/Cap| Memory-Usage | GPU-Util Compute M. |
|===============================+======================+======================|
| 0 TITAN RTX Off | 00000000:01:00.0 Off | N/A |
|ERR! 47C P0 N/A / N/A | 0MiB / 24220MiB | 0% Default |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes: GPU Memory |
| GPU PID Type Process name Usage |
|=============================================================================|
| No running processes found |
+-----------------------------------------------------------------------------+

@romanovvlad
Copy link
Contributor

romanovvlad commented Aug 27, 2020

@AlexeySachkov Could you please help with inline asm tests?

@AlexeySachkov
Copy link
Contributor

AlexeySachkov commented Aug 27, 2020

@AlexeySachkov Could you please help with inline asm tests?

These tests do not use inline asm and they pass in other PRs. This PR updates Intel GPU driver, but by some reason causes failures on CUDA device, which seems strange

The easiest way would be disabling them on CUDA by adding // UNSUPPORTED: cuda at the beginning of those files (the rest of inline asm tests already disabled on CUDA)

@yanfeng3721
Copy link
Contributor

yanfeng3721 commented Aug 28, 2020

@yinyangsx , @romanovvlad , could you please rerun the pre commit test?

@romanovvlad romanovvlad merged commit 5f38e4b into intel:sycl Aug 31, 2020
vladimirlaz
vladimirlaz reviewed Aug 31, 2020
View reviewed changes
buildbot/dependency.conf
# https://github.com/intel/llvm/releases/download/2020-WW31/win-oclcpuexp-2020.10.7.0.15_rel.zip
ocl_cpu_rt_ver_win=2020.10.7.0.15
# Same GPU driver supports Level Zero and OpenCL:
# https://github.com/intel/compute-runtime/releases/tag/20.29.17408
Copy link
Contributor

@vladimirlaz vladimirlaz Aug 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update links with proper URLs

@yinyangsx
Copy link

yinyangsx commented Sep 1, 2020

The Linux Lit test for this PR is incorrect. Please see the log. There is no GPU device found. @romanovvlad and @yanfeng3721 could you please revert this?
llvm-lit: /localdisk2/sycl_ci/buildbot/worker/sycl-ubu-x64-pr/llvm.obj/bin/../../llvm.src/llvm/utils/lit/lit/llvm/config.py:347: note: using clang: /localdisk2/sycl_ci/buildbot/worker/sycl-ubu-x64-pr/llvm.obj/bin/clang
llvm-lit: /localdisk2/sycl_ci/buildbot/worker/sycl-ubu-x64-pr/llvm.src/sycl/test/lit.cfg.py:79: note: Backend (SYCL_BE): PI_LEVEL_ZERO
llvm-lit: /localdisk2/sycl_ci/buildbot/worker/sycl-ubu-x64-pr/llvm.src/sycl/test/lit.cfg.py:141: warning: CPU device not found
llvm-lit: /localdisk2/sycl_ci/buildbot/worker/sycl-ubu-x64-pr/llvm.src/sycl/test/lit.cfg.py:176: warning: GPU device not found
llvm-lit: /localdisk2/sycl_ci/buildbot/worker/sycl-ubu-x64-pr/llvm.src/sycl/test/lit.cfg.py:192: warning: Accelerator device not found

yanfeng3721 added a commit to yanfeng3721/llvm that referenced this pull request Sep 1, 2020
@yanfeng3721
Revert "Uplift GPU RT version for Linux to 20.33.17675 (intel#2374)"
bebc446 
This reverts commit 5f38e4b.
bader pushed a commit that referenced this pull request Sep 1, 2020
@yanfeng3721
Revert "Uplift GPU RT version for Linux to 20.33.17675 (#2374)" (#2401)
eb14539 
This reverts commit 5f38e4b.
jsji pushed a commit that referenced this pull request Feb 22, 2024
@svenvh @sys-ce-bb
Add SPIR-V 1.5 enum value (#2374)
fa9dd79 
Recognize SPIR-V 1.5 modules and allow specifying the
`--spirv-max-version=1.5` option.

This does not implement any SPIR-V 1.5 functionality yet, so mark
1.5 as "experimental".

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@747ef0f0ec03a25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bader bader Awaiting requested review from bader

@DoyleLi DoyleLi Awaiting requested review from DoyleLi

@yinyangsx yinyangsx Awaiting requested review from yinyangsx

@romanovvlad romanovvlad Awaiting requested review from romanovvlad

2 more reviewers

@vladimirlaz vladimirlaz vladimirlaz approved these changes

@yanfeng3721 yanfeng3721 yanfeng3721 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bb-sycl @bader @yinyangsx @romanovvlad @AlexeySachkov @yanfeng3721 @vladimirlaz