[SYCL] Improvements to SYCL_PI_TRACE #2357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than blind size_t *, introduce some simple data structures for passing Origin and Region arguments to plugin interface. This improves code readability, can be dispatched by PI_TRACE improving output, and allows us to more easily see bugs/confusion in how certain 2D/3D arguments aren't being passed correctly to existing Rect/Image operations Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Co-authored-by: smaslov-intel <[email protected]>
bader
reviewed
Aug 23, 2020
romanovvlad
reviewed
Aug 24, 2020
keryell
reviewed
Aug 24, 2020
Signed-off-by: Chris Perkins <[email protected]>
romanovvlad
previously approved these changes
Aug 26, 2020
smaslov-intel
previously approved these changes
Aug 27, 2020
Contributor
Author
|
@smaslov-intel as code-owner do you do the merging? |
Contributor
Nope, I don't have submitting rights. Would you also please take this change: #2357 (comment)? |
Signed-off-by: Chris Perkins [email protected] Co-authored-by: smaslov-intel <[email protected]>
cperkinsintel
dismissed stale reviews from smaslov-intel and romanovvlad
via
7f31465
smaslov-intel
approved these changes
Aug 27, 2020
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
[HIP] Fix error code for unsupported program info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than blind size_t *, introduce some simple data structures for passing Origin and Region arguments to plugin interface. This improves code readability, can be dispatched by PI_TRACE improving output, and allows us to more easily see bugs/confusion in how certain 2D/3D arguments aren't being passed correctly to existing Rect/Image operations
Signed-off-by: Chris Perkins [email protected]