[SYCL] Correction to handler::require API #2325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rdeodhar <[email protected]>
Contributor
|
@rdeodhar, please, provide description of the problem this patch solves. |
Contributor
|
/summary:run |
romanovvlad
approved these changes
Aug 17, 2020
Contributor
romanovvlad
left a comment
romanovvlad
left a comment
There was a problem hiding this comment.
LGTM, but, please, address Sergey's comment.
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
…msan [DeviceMSAN] Support MemorySanitizer for device offloading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix corrects the definition of the handler::require API in our headers to match the SYCL specification.
The SYCL spec defines the accessor parameter of "require" to be passed by value. Our headers defined the API to take an accessor by reference.
This PR changes the accessor parameter from reference to value.
Signed-off-by: rdeodhar [email protected]