[SYCL][Driver] Rename -fsycl-std-optimizations to -fsycl-early-optimizations #2316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
requested review from
a team,
AGindinson,
Fznamznon,
elizabethandrews,
mdtoguchi and
premanandrao
as code owners
Contributor
Author
|
@intel/llvm-reviewers-runtime, ping. |
againull
approved these changes
Aug 14, 2020
s-kanaev
approved these changes
Aug 14, 2020
Contributor
s-kanaev
left a comment
s-kanaev
left a comment
There was a problem hiding this comment.
Changes in RT tests LGTM.
jsji
pushed a commit
that referenced
this pull request
Mar 14, 2024
Translator accepting two formats currently - SPIR-V and SPT. SPT is a textual format used internally for tests without any formal specification. Parsing a textual format is slower than binary format and SPT also is less strict in comparison to SPIRV. Because parsing in Translator is organized around iostream interfaces and implementations are mostly shared, the binary format is parsed much slower than it can be. The commit starts an effort of splitting implementations to make SPIR-V hot path faster and easier to read. In addition to that from both implementations the Decoder class is removed - it doesn't bring any important functionality which couldn't be solved by few lines of explicit simple code. Original commit: KhronosGroup/SPIRV-LLVM-Translator@d54f77c5dd695cc
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Change `urSuggestMaxCooperativeGroupCountExp` to accept ND size parameter
iclsrc
pushed a commit
that referenced
this pull request
Sep 27, 2025
d54f77c5 ("[NFC] Split of SPT and SPIR-V in header parsing (#2316)",
2024-03-11) made a copy of the error log, with the presumably unintended
consequence that errors are no longer propagated back to the SPIRVModule
itself.
Original commit:
KhronosGroup/SPIRV-LLVM-Translator@3d58c69cf2f3704
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.