[SYCL][Driver] Fix issue that sycl is not able to print internal defi… #2188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nes. Signed-off-by: haonanya <[email protected]>
Signed-off-by: haonanya <[email protected]>
mdtoguchi
reviewed
Jul 29, 2020
Contributor
mdtoguchi
left a comment
mdtoguchi
left a comment
There was a problem hiding this comment.
LGTM, but it looks like you have some tests that need addressing that are using preprocessing options.
…ya/driver/print-internal-defines-for-sycl
Signed-off-by: haonanya [email protected] Co-authored-by: mdtoguchi <[email protected]>
…' of https://github.com/haonanya/llvm into private/haonanya/driver/print-internal-defines-for-sycl
… defines only. Signed-off-by: haonanya <[email protected]>
Contributor
Author
|
@mdtoguchi . Modified the patch and all pre-check-in pass already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang++ -fsycl -dM -E -x c++ /dev/null is not able to print internal defines, the patch aims to fix this issue. It will emit the output to terminal as well as produce the bundled .ii file.
Signed-off-by: haonanya [email protected]