[SYCL] Fix translation of user functions into SPIR-V instructions #2146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AlexeySotkin
left a comment
AlexeySotkin
left a comment
There was a problem hiding this comment.
Please squash your commits and add a meaningful commit message.
Contributor
There was a problem hiding this comment.
Please make the test shorter. You only need a call to the BitReverse function.
Contributor
There was a problem hiding this comment.
I think these 2 lines capture the same ID and one of them can be removed.
User may get their function a name the same as SPIR-V instruction. In that case thier function call will be translated to SPIR-V instruction call. The only functions that should be translated to SPIR-V instructions are SPIR-V built-ins and they should have __spirv prefix. Add checking for __spirv prefix in demangler to filter SPIR-V built-ins from other function calls.
MochalovaAn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User may get their function a name the same as SPIR-V instruction.
In that case thier function call will be translated to SPIR-V instruction call.
The only functions that should be translated to SPIR-V instructions are SPIR-V built-ins
and they should have __spirv prefix.
Add checking for __spirv prefix in demangler to filter SPIR-V built-ins from other function calls
Signed-off-by: amochalo [email protected]