[SYCL] Fix segmentation fault in program manager #2057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Vodopyanov <[email protected]>
Signed-off-by: Dmitry Vodopyanov <[email protected]>
Contributor
|
@dm-vodopyanov , please provide some details of the problem and the fix in the PR description and commit message. |
kbobrovs
suggested changes
Jul 8, 2020
Contributor
Author
|
@kbobrovs, added description, please review. |
romanovvlad
approved these changes
Jul 9, 2020
Contributor
romanovvlad
left a comment
romanovvlad
left a comment
There was a problem hiding this comment.
LGTM, but I would like @kbobrovs to approve as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes sporadic segmentation fault caused by data race in
NativeProgramsvariable ofProgramManagerclass.According to documentation, an access to this variable should be synchronized via the same lock as program cache but there was a lack of lock guard for
NativePrograms[Res] = &Img;in sycl/source/detail/program_manager/program_manager.cpp. Added missing lock guard.