-
Notifications
You must be signed in to change notification settings - Fork 795
[Benchmarks] Pin benchmarks to small set of cores #20403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
10804b3 to
8855934
Compare
|
Test run on the PVC perf machine: https://github.com/intel/llvm/actions/runs/18679758239/job/53258464661 |
For better results stability, pin benchmark binaries to four cores with the maximum available frequency.
lslusarczyk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some suggestions
8855934 to
e5b651a
Compare
e5b651a to
670adfc
Compare
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@intel/dpcpp-devops-reviewers, is adding |
CPU driver sometimes changes a bit the maximum frequency of selected cores. This, however, doesn't impact benchmark results greatly. Assumption of having first cores with highest frequency is enough.
|
@intel/dpcpp-devops-reviewers, please review. This change will help stabilize benchmark results on the new BMG machine. Note that benchmark job that actually uses numactl installed passed: https://github.com/intel/llvm/actions/runs/19104203407/job/55173686283. As to the e2e test failure, it's unrelated. |
|
@intel/dpcpp-devops-reviewers, a friendly ping. This patch should also fix failing benchmarks on BMG machine: https://github.com/intel/llvm/actions/runs/19328176408/job/55285113356#step:19:2263 |
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx, LGTM
This reverts commit 127b519.
|
@PatKamin Is this ready for merge? Is the benchmark CI fail unrelated? |
For better results stability, pin benchmark binaries to four cores with the maximum available frequency.