[NFC][SYCL] Change ExtOneapiBarrierOpt to use TEST_F
#20241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
approved these changes
Sep 29, 2025
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Windows BMG E2E test failure is unrelated. |
AlexeySachkov
added a commit
that referenced
this pull request
Sep 30, 2025
This is a cherry-pick of #20159 (and #20241) **Problem** As an optimization in `ext_oneapi_submit_barrier`, for in-order queue, when waitlist is empty, we return the last event, if it is available. However, after #18277, we no longer store last event and instead submit a marker to get the last event. And this caused performance regression in some of our internal benchmarks. **Solution** Don't return last event and instead submit a barrier with empty waitlist. Patch-by: Udit Kumar Agarwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unit test failed in sycl-rel and internal CI (see https://github.com/intel/llvm/actions/runs/18096621667/job/51489057567) because the test is using members of class
ExtOneapiBarrierOptTest, and these members need to be re-initialized in between two test runs.TEST_Fdoes exactly that.