Skip to content

[SYCL][NFC] Queue class ABI cleanup [1/N] #20153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

[SYCL][NFC] Queue class ABI cleanup [1/N] #20153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sycl/include/sycl/queue.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,10 +401,12 @@ class __SYCL_EXPORT queue : public detail::OwnerLessBase<queue> {
typename detail::is_backend_info_desc<Param>::return_type
get_backend_info() const;

#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
private:
// A shorthand for `get_device().has()' which is expected to be a bit quicker
// than the long version
bool device_has(aspect Aspect) const;
#endif

public:
/// Submits a command group function object to the queue, in order to be
Expand Down Expand Up @@ -3453,14 +3455,18 @@ class __SYCL_EXPORT queue : public detail::OwnerLessBase<queue> {
CodeLoc);
}

#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
/// @brief Returns true if the queue was created with the
/// ext::codeplay::experimental::property::queue::enable_fusion property.
///
/// Equivalent to
/// `has_property<ext::codeplay::experimental::property::queue::enable_fusion>()`.
///
// TODO(#15184) Remove this function in the next ABI-breaking window.
__SYCL_DEPRECATED(
"Support for ext_codeplay_kernel_fusion extesnsion is dropped")
bool ext_codeplay_supports_fusion() const;
#endif

/// Shortcut for executing a graph of commands.
///
Expand Down
2 changes: 2 additions & 0 deletions sycl/source/queue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,13 +453,15 @@ event queue::memcpyFromDeviceGlobal(void *Dest, const void *DeviceGlobalPtr,
/*CallerNeedsEvent=*/true);
}

#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
bool queue::device_has(aspect Aspect) const {
// avoid creating sycl object from impl
return impl->getDeviceImpl().has(Aspect);
}

// TODO(#15184) Remove this function in the next ABI-breaking window.
bool queue::ext_codeplay_supports_fusion() const { return false; }
#endif

sycl::detail::optional<event> queue::ext_oneapi_get_last_event_impl() const {
if (!is_in_order())
Expand Down