[SYCL][NFC] Don't use std::ignore
#20087
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its implementation involve templates, which means slow compile times.
[[maybe_unused]]
does the job just fine, but it is cheaper.This patch only changed
sycl/
headers, ignoringsycl/ext
headers.We still maintain the fact that our SYCL RT library should be buildable with an old GCC (7.5.0 to be precise) and it doesn't support
[[maybe_unused]]
C++17 attribute. To avoid the attribute "leaking" into the library code, some of the image accessor code has been split into multiple headers to reduce the surface of what is being included from the library sources.