Skip to content

Conversation

RossBrunton
Copy link
Contributor

This is primarily for liboffload which doesn't support it yet, and
probably never will for AMD devices (which don't seem to have this
functionality). In theory it will also affect level zero, at least
according to a comment, but urProgramGetFunctionPointer seems to be
implemented there.

@RossBrunton RossBrunton requested a review from a team as a code owner August 14, 2025 09:33
@RossBrunton RossBrunton requested a review from a team August 14, 2025 09:34
}

ASSERT_EQ_RESULT(UR_RESULT_ERROR_INVALID_KERNEL_NAME, result);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this is nonsensical error message (functions are not kernels). But that's probably a change to do elsewhere.

@callumfare
Copy link
Contributor

It doesn't look like the SYCL runtime uses this function at all, do we still need it?

This is primarily for liboffload which doesn't support it yet, and
probably never will for AMD devices (which don't seem to have this
functionality). In theory it will also affect level zero, at least
according to a comment, but urProgramGetFunctionPointer seems to be
implemented there.
@RossBrunton
Copy link
Contributor Author

@callumfare I think it was added to support calling function pointers from device code, but all information about that has apparently been purged from the internet.

Still, if nobody uses it, then that's all the more reason to make it an optional feature. :P

@RossBrunton
Copy link
Contributor Author

@intel/llvm-gatekeepers Please merge.

@intel/unified-runtime-reviewers-level-zero This change doesn't touch any Level Zero related code, however it does change a test which indicated that L0 was misbehaving. This change makes the "misbehaving" behaviour valid. Just pinging as an FYI.

@sommerlukas sommerlukas merged commit 0d4249c into intel:sycl Aug 15, 2025
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants