[DevMSAN] Unpoison sret argument for builtin function to get spec constant #19800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stant For builtin func like "__sycl_getComposite2020SpecConstantValue", if structs which are larger than 64b will be returned via sret arguments and will be initialized inside the function. So we need to unpoison the sret arguments.
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull Request Overview
This pull request implements support for unpoisoning sret (struct return) arguments for SYCL builtin functions that return large structs (>64 bits) in MemorySanitizer. The main change addresses the fact that these builtin functions initialize struct return values internally, requiring the memory sanitizer to mark these return values as clean.
- Adds special handling for
__sycl_getComposite2020SpecConstantValuebuiltin function in MemorySanitizer - Implements a new runtime function
__msan_unpoison_shadowfor unpoisoning arbitrary memory regions - Updates test configurations to set
ZE_AFFINITY_MASK=0for sanitizer tests
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp | Adds detection and handling of SYCL builtin functions with sret parameters, unpoisoning their return values |
| libdevice/sanitizer/msan_rtl.cpp | Implements new __msan_unpoison_shadow runtime function and refactors debug message constants |
| llvm/test/Instrumentation/MemorySanitizer/SPIRV/spec_constants.ll | Adds test case verifying correct unpoisoning of sret arguments for spec constant builtin functions |
| sycl/test-e2e/ThreadSanitizer/lit.local.cfg | Sets ZE_AFFINITY_MASK environment variable for test isolation |
| sycl/test-e2e/MemorySanitizer/lit.local.cfg | Sets ZE_AFFINITY_MASK environment variable for test isolation |
| sycl/test-e2e/AddressSanitizer/lit.local.cfg | Sets ZE_AFFINITY_MASK environment variable for test isolation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For builtin func like "__sycl_getComposite2020SpecConstantValue", if structs which are larger than 64b will be returned via sret arguments and will be initialized inside the function. So we need to unpoison the sret arguments.