[DevSAN] Change DeviceType to specialization constant #19798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow backend compiler to eliminte unnecessary code to reduce kernel code size.
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
| @@ -21,6 +21,9 @@ namespace ur_sanitizer_layer { | |||
|
|
|||
| enum class DeviceType : uint32_t { UNKNOWN = 0, CPU, GPU_PVC, GPU_DG2 }; | |||
|
|
|||
| // Try to use a larger ID number to avoid conflict with user ID. | |||
| constexpr int SpecConstantDeviceTyID = 99; | |||
There was a problem hiding this comment.
I'm not sure this value is high enough to avoid conflicts. Normally the frontend would give our specialization constants a value based on the other specialization constants in the same TU. Is there a way we could leverage this to get a guaranteed unique ID?
Of course, it begs the question how the unified runtime would know what it would be. Maybe we can make the frontend offset the start of its assigned specialization constants based when the sanitizer is enabled? That way this could use 0 and the other specialization constants would start from 1 and increment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow backend compiler to eliminte unnecessary code to reduce kernel code size.