[UR][CTS] Update urEventSetCallback test to not assume sync. events #19788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
force-pushed
the
callbacktest
branch
from
38e8cc6 to
107cfb4
Compare
Before this patch, urEventSetCallbackTest assumed that the callback would be executed during and blocking urEventWait or urEventRelease. This change removes that assumptions by having the main thread wait until the callback is complete.
RossBrunton
force-pushed
the
callbacktest
branch
from
107cfb4 to
046e3f9
Compare
aarongreig
approved these changes
Aug 15, 2025
|
@intel/llvm-gatekeepers Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, urEventSetCallbackTest assumed that the callback
would be executed during and blocking urEventWait or urEventRelease.
This change removes that assumptions by having the main thread wait
until the callback is complete.