[UR][CMake] Fix OpenCL target error on rebuild #19740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarnie, Nick <[email protected]>
Contributor
Author
pbalcer
approved these changes
Aug 7, 2025
Contributor
Author
|
Thanks Piotr! |
ggojska
pushed a commit
to ggojska/llvm
that referenced
this pull request
Aug 12, 2025
The problem was `OpenCL_FOUND` was getting set to `TRUE` on the second invocation of the module because `find_package` was finding the `FetchContent` clone in `SOURCE_TREE/build/__deps`. We use `OpenCL_FOUND` to specifically refer to external system-wide installs, so use `NO_CMAKE_PACKAGE_REGISTRY` to make sure we don't find FetchContent clones. Also not related to the fix here but re-order `FetchContent_Declare` `FetchContent_GetProperties`, the `Declare` should come first and we `MakeAvailable` should not be inside the `if`, we only check if it's populated to print the message. Closes: intel#19737 Signed-off-by: Sarnie, Nick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was
OpenCL_FOUNDwas getting set toTRUEon the second invocation of the module becausefind_packagewas finding theFetchContentclone inSOURCE_TREE/build/__deps.We use
OpenCL_FOUNDto specifically refer to external system-wide installs, so useNO_CMAKE_PACKAGE_REGISTRYto make sure we don't find FetchContent clones.Also not related to the fix here but re-order
FetchContent_DeclareFetchContent_GetProperties, theDeclareshould come first and weMakeAvailableshould not be inside theif, we only check if it's populated to print the message.Closes: #19737