Refactor SYCL compilation with #125556 changes from LLVM community #19709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srividya-sundaram
changed the title
mdtoguchi
reviewed
Aug 6, 2025
mdtoguchi
reviewed
Aug 6, 2025
adding default TC for SYCL old model and some TT.isSPIROrSPIRV() in CompilerInvocation.cpp
Cleanup --offload-targets code for SYCL
mdtoguchi
reviewed
Aug 13, 2025
srividya-sundaram
changed the title
mdtoguchi
reviewed
Aug 14, 2025
mdtoguchi
approved these changes
Aug 14, 2025
Thank YOU! |
|
ping @intel/dpcpp-cfe-reviewers |
Fznamznon
approved these changes
Aug 18, 2025
There was a problem hiding this comment.
I think we should add clang/include/clang/Basic/DiagnosticDriverKinds.td file to the list of files owned by the https://github.com/orgs/intel/teams/dpcpp-clang-driver-reviewers team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch reworks the creation of SYCL offloading toolchains, now basing it on the Offloading Kind and the target triple string, passed via either
--offload-targetsor--offload-arch.The following PRs/patches from LLVM community have been included in this patch:
llvm/llvm-project#125556
llvm/llvm-project@08ac781
llvm/llvm-project@dc87a14
llvm/llvm-project@efffa42
d65cc97
llvm/llvm-project@34447ef
https://github.com/intel-restricted/applications.compilers.llvm-project/pull/30861
llvm/llvm-project@4f58c82
llvm/llvm-project@56ba118