Skip to content

[SYCL] Update list of barriers after back-to-back elimination #19700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 7, 2025
Merged

[SYCL] Update list of barriers after back-to-back elimination #19700

merged 3 commits into from
Aug 7, 2025

Conversation

@MrSidims
Copy link
Contributor

@MrSidims MrSidims commented Aug 4, 2025

No description provided.

@MrSidims MrSidims requested a review from a team as a code owner August 4, 2025 18:22
maarquitos14
maarquitos14 approved these changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a test that shows why we need this patch? Can be done in a subsequent patch too.

@MrSidims
adjust test
bba0b73 
Signed-off-by: Sidorov, Dmitry <[email protected]>
@MrSidims
Copy link
Contributor Author

MrSidims commented Aug 5, 2025

@maarquitos14 I took a look at the failing test - actually, the test was incorrect as the pass shouldn't have updating memory semantics of the barrier in the case. So probably just updating it is fine.

@MrSidims
Copy link
Contributor Author

MrSidims commented Aug 7, 2025 •
edited
Loading

@intel/llvm-gatekeepers not sure if I see from where the error comes, could you please assist me finding the error?
2025-08-07T10:23:51.3764619Z
2025-08-07T10:23:51.3764699Z [ PASSED ] 2 tests.
2025-08-07T10:23:51.3764795Z
2025-08-07T10:23:51.3764870Z ninja: build stopped: subcommand failed.
2025-08-07T10:23:51.5025570Z ##[error]Process completed with exit code 1.
2025-08-07T10:23:51.5234664Z ##[group]Run cmake --build build --target check-llvm-spirv
2025-08-07T10:23:51.5234978Z �[36;1mcmake --build build --target check-llvm-spirv�[0m

It might be an infrastructure issue, but I'd like to be sure as I'm fixing an UB causing sporadic SYCL code compilation crash.

@MrSidims
Copy link
Contributor Author

MrSidims commented Aug 7, 2025 •
edited
Loading

Okay, seems like the windows LIT failure is known and at least of the same (unknown) origin as #19696 (comment) . With that @intel/llvm-gatekeepers I believe this patch can be merged.

@sarnex sarnex merged commit dc8068f into intel:sycl Aug 7, 2025
43 of 47 checks passed
ggojska pushed a commit to ggojska/llvm that referenced this pull request Aug 12, 2025
@MrSidims @ggojska
[SYCL] Update list of barriers after back-to-back elimination (intel#…
048b74e 
…19700)

Signed-off-by: Sidorov, Dmitry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maarquitos14 maarquitos14 maarquitos14 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MrSidims @maarquitos14 @sarnex