[UR][Offload] Queue flag and out-of-order queue support #19531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
RossBrunton
commented
Jul 21, 2025
| return ReturnValue(uint32_t{0}); | ||
| case UR_DEVICE_INFO_QUEUE_PROPERTIES: | ||
| case UR_DEVICE_INFO_QUEUE_ON_HOST_PROPERTIES: | ||
| case UR_DEVICE_INFO_QUEUE_ON_DEVICE_PROPERTIES: |
Contributor
Author
There was a problem hiding this comment.
To be honest, I'm not entirely sure what the difference between "on host" and "on device" properties are.
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
reviewed
Jul 21, 2025
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
commented
Jul 21, 2025
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Out of order support is similar to CUDA and HIP; there's a pool of queues, and incoming tasks are allocated to the queues round-robin style. In addition, the memcpy helper function now creates and destroys an ol queue, since they are cheap to create and we don't need it to hang around. In addition, flags are now parsed by `urQueueCreate` and can be queried with `urQueueGetInfo`. This determines whether the queue is in-order or out-of-order.
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
reviewed
Jul 24, 2025
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
callumfare
approved these changes
Jul 24, 2025
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
reviewed
Jul 24, 2025
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
approved these changes
Jul 24, 2025
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@intel/llvm-gatekeepers Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out of order support is similar to CUDA and HIP; there's a pool of
queues, and incoming tasks are allocated to the queues round-robin
style. In addition, the memcpy helper function now creates and destroys
an ol queue, since they are cheap to create and we don't need it to
hang around.
In addition, flags are now parsed by
urQueueCreateand can be queriedwith
urQueueGetInfo. This determines whether the queue is in-orderor out-of-order.