[UR][CUDA][HIP] Fix command buffer update with shared kernel handles #19479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix issue where updating multiple nodes with the same UR kernel handle would give incorrect results due to arg caching. - Add SYCL E2E test based on the example in the issue that reported this.
EwanC
reviewed
Jul 16, 2025
Bensuo
changed the title
EwanC
approved these changes
Jul 16, 2025
Contributor
EwanC
left a comment
EwanC
left a comment
There was a problem hiding this comment.
LGTM, will refrain from too many comments on the new test so it stays similar to the issue.
- Remove printfs - Replace literals with defined variables - Add required aspect for shared USM
reble
approved these changes
Jul 16, 2025
bader
changed the title
Contributor
Author
|
@intel/llvm-gatekeepers This should be ready to merge now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue reported in #19450