[NFC][SYCL] Add devices_range helper to cleanup persistent_device_code_cache
#19405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code_cache` Same idea as with `nodes_range` from intel#19295, this PR generalizes the approach and makes both `nodes_|devices_range` use the same common utility. `persistent_device_code_cache` was chosen randomly to apply simplifications by using the new helper. Subsequent PRs will likely make wider usage of it.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Jul 11, 2025
reble
approved these changes
Jul 11, 2025
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jul 15, 2025
`devices_range` helper was added in intel#19405 to facilitate ongoing refactoring of using more raw ptr/ref to `*_impl` objects.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jul 15, 2025
`devices_range` helper was added in intel#19405 to facilitate ongoing refactoring of using more raw ptr/ref to `*_impl` objects.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jul 15, 2025
`devices_range` helper was added in intel#19405 to facilitate ongoing refactoring of using more raw ptr/ref to `*_impl` objects. Also update some of the callsites that can use that instead of more expensive `get_info<info::context::devices>()`.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jul 15, 2025
`devices_range` helper was added in intel#19405 to facilitate ongoing refactoring of using more raw ptr/ref to `*_impl` objects. Also update some of the callsites that can use that instead of more expensive `get_info<info::context::devices>()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same idea as with
nodes_rangefrom#19295, this PR generalizes the approach and makes both
nodes_|devices_rangeuse the same common utility.persistent_device_code_cachewas chosen randomly to apply simplifications by using the new helper. Subsequent PRs will likely make wider usage of it.